netdev - [PATCH can v3 0/2] can: m_can: fix struct net_device_ops::{open,stop} callbacks under high bus load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240910-can-m_can-fix-ifup-v3-0-6c1720ba45ce@pengutronix.de>
Date: Tue, 10 Sep 2024 19:15:27 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Jake Hamby <Jake.Hamby@...edyne.com>, 
 Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
 Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Dong Aisheng <b29396@...escale.com>, Varka Bhadram <varkabhadram@...il.com>
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>
Subject: [PATCH can v3 0/2] can: m_can: fix struct
 net_device_ops::{open,stop} callbacks under high bus load

Under high CAN-bus load the struct net_device_ops::{open,stop}
callbacks (m_can_open(), m_can_close()) don't properly start and
shutdown the device.

Fix the problems by re-arranging the order of functions in
m_can_open() and m_can_close().

Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
---
Changes in v3:
- 1/2: m_can_close(), m_can_open(): move location of napi_disable(),
  call can_rx_offload_disable() for peripherals napi_disable()
  otherwise
- 1/2: add Signed-off-by: Jake Hamby <Jake.Hamby@...edyne.com>
- Link to v2: https://patch.msgid.link/20240909-can-m_can-fix-ifup-v2-0-2b35e624a089@pengutronix.de

Changes in v2:
- 1/2: split timestamp wraparound changes into separate patch
- 1/2: added "Not-Signed-off-by: Hamby, Jake (US) <Jake.Hamby@...edyne.com>"
- 2/2: new patch: fix order of clock shutdown
- Link to v1: https://patch.msgid.link/DM8PR14MB5221D9DD3A7F2130EF161AF7EF9E2@DM8PR14MB5221.namprd14.prod.outlook.com

---
Jake Hamby (1):
      can: m_can: enable NAPI before enabling interrupts

Marc Kleine-Budde (1):
      can: m_can: m_can_close(): stop clocks after device has been shut down

 drivers/net/can/m_can/m_can.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
---
base-commit: 48aa361c5db0b380c2b75c24984c0d3e7c1e8c09
change-id: 20240909-can-m_can-fix-ifup-770306ca4aca

Best regards,
-- 
Marc Kleine-Budde <mkl@...gutronix.de>