netdev - Re: [PATCH v4 5/5] wifi: wilc1000: Add WILC3000 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o74waymg.fsf@kernel.org>
Date: Tue, 10 Sep 2024 08:03:51 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Marek Vasut <marex@...x.de>
Cc: Ajay.Kathat@...rochip.com,  linux-wireless@...r.kernel.org,
  davem@...emloft.net,  alexis.lothore@...tlin.com,
  claudiu.beznea@...on.dev,  conor+dt@...nel.org,  edumazet@...gle.com,
  kuba@...nel.org,  krzk+dt@...nel.org,  pabeni@...hat.com,
  robh@...nel.org,  devicetree@...r.kernel.org,  netdev@...r.kernel.org
Subject: Re: [PATCH v4 5/5] wifi: wilc1000: Add WILC3000 support

Marek Vasut <marex@...x.de> writes:

> On 9/9/24 11:11 PM, Ajay.Kathat@...rochip.com wrote:
>
> [...]
>
>>>> Does it make sense to add a module parameter for device type(wilc1000 or
>>>> wilc3000) to address device-specific featurization.
>>>
>>> We don't do hacks like that in upstream, it's expected that the driver
>>> does this all automatically.
>>
>> Marek has already submitted the patch to delay calling
>> wiphy_register() so it
>> should work at run time for both the devices.
>> I'm just curious to know for which scenario the module parameters should be
>> used. Can it be used for enabling or disabling any feature, configuring any
>> parameters, instead of complete device-specific featurization.
>
> Module parameters are applicable for tunables which cannot be
> otherwise configured at runtime. Runtime configuration is always
> preferable. For the wilc, I don't think there is anything which has to
> be a module parameter, maybe firmware filename could be it.

Nowadays module parameters are frowned upon, apparently some subsystems
have even banned adding new module parameters. In wireless we have been
more lax and have allowed new module parameters in some cases with good
justification, but it's still rare.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches