netdev - Re: [Intel-wired-lan] [PATCH v7 net-next 01/15] genetlink: extend info user-storage to match NL cb ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09022c4f-37bf-4119-bf64-87e82af3673e@molgen.mpg.de>
Date: Tue, 10 Sep 2024 09:09:37 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Donald Hunter <donald.hunter@...il.com>,
 John Fastabend <john.fastabend@...il.com>,
 Jamal Hadi Salim <jhs@...atatu.com>, edumazet@...gle.com,
 Madhu Chittim <madhu.chittim@...el.com>, anthony.l.nguyen@...el.com,
 Simon Horman <horms@...nel.org>, przemyslaw.kitszel@...el.com,
 Jakub Kicinski <kuba@...nel.org>, intel-wired-lan@...ts.osuosl.org,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>
Subject: Re: [Intel-wired-lan] [PATCH v7 net-next 01/15] genetlink: extend
 info user-storage to match NL cb ctx

Dear Paolo,


Thank you for your patch.

Am 10.09.24 um 00:09 schrieb Paolo Abeni:
> This allows a more uniform implementation of non-dump and dump
> operations, and will be used later in the series to avoid some
> per-operation allocation.
> 
> Additionally rename the NL_ASSERT_DUMP_CTX_FITS macro, to
> fit a more extended usage.

Should a resent be necessary, you could also mention the new name 
`NL_ASSERT_CTX_FITS` in the commit message. (Maybe even a separate 
commit, so the actual change is easier to review.)

> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>   drivers/net/vxlan/vxlan_mdb.c        | 2 +-
>   include/linux/netlink.h              | 5 +++--
>   include/net/genetlink.h              | 8 ++++++--
>   net/core/netdev-genl.c               | 2 +-
>   net/core/rtnetlink.c                 | 2 +-
>   net/devlink/devl_internal.h          | 2 +-
>   net/ethtool/rss.c                    | 2 +-
>   net/netfilter/nf_conntrack_netlink.c | 2 +-
>   net/netlink/genetlink.c              | 4 ++--
>   9 files changed, 17 insertions(+), 12 deletions(-)

[…]

With this:

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul