netdev - Re: [PATCH net v1] dev_ioctl: fix the type of ifr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240911083013.61017-1-atlas.yu@canonical.com>
Date: Wed, 11 Sep 2024 16:30:12 +0800
From: Atlas Yu <atlas.yu@...onical.com>
To: edumazet@...gle.com
Cc: atlas.yu@...onical.com,
	davem@...emloft.net,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	stephen@...workplumber.org
Subject: Re: [PATCH net v1] dev_ioctl: fix the type of ifr_flags

> On Wed, Sep 11, 2024 at 3:21 PM
> Eric Dumazet <edumazet@...gle.com> wrote:
> 
> Note that rtnetlink gets the 32bit flags already, this has been the
> case for 20 years or more.
> 
> include/uapi/linux/rtnetlink.h:566:     unsigned        ifi_flags;
>          /* IFF_* flags  */
> 
> net/core/rtnetlink.c  : rtnl_fill_ifinfo(...)
> 
> ifm->ifi_flags = dev_get_flags(dev);
> 
> iproute2 also displays more than 16 bits in print_link_flags()

Thank you Eric, I am switching to the netlink API for my use case.