netdev - Re: [PATCH net-next 2/3] selftests/net: packetdrill: import tcp/zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66e1a30f285b0_117c772948@willemb.c.googlers.com.notmuch>
Date: Wed, 11 Sep 2024 10:02:55 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Matthieu Baerts <matttbe@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 netdev@...r.kernel.org
Cc: davem@...emloft.net, 
 kuba@...nel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 ncardwell@...gle.com, 
 Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 2/3] selftests/net: packetdrill: import
 tcp/zerocopy

Matthieu Baerts wrote:
> Hi Willem,
> 
> On 11/09/2024 01:59, Willem de Bruijn wrote:
> > From: Willem de Bruijn <willemb@...gle.com>
> > 
> > Same as initial tests, import verbatim from
> > github.com/google/packetdrill, aside from:
> > 
> > - update `source ./defaults.sh` path to adjust for flat dir
> > - add SPDX headers
> > - remove author statements if any
> > 
> > Also import set_sysctls.py, which many scripts depend on to set
> > sysctls and then restore them later. This is no longer strictly needed
> > for namespacified sysctl. But not all sysctls are namespacified, and
> > doesn't hurt if they are.
> 
> Then you also need to list this new file in the Makefile, added to
> TEST_INCLUDES.

Argh. Indeed. Thanks, will do!
 
> (Also, even if I'm sure that's fine, Git complained when I applied this
> patch)
> 
>   .git/rebase-apply/patch:216: new blank line at EOF.
>   +
>   .git/rebase-apply/patch:267: new blank line at EOF.
>   +
>   .git/rebase-apply/patch:712: new blank line at EOF.
>   +
>   .git/rebase-apply/patch:776: new blank line at EOF.
>   +
>   warning: 4 lines add whitespace errors.

I'll trim these too.