[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5b013e5c-7598-4b84-a60f-a3f58f70afaa@kernel.org>
Date: Wed, 11 Sep 2024 17:07:35 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>,
Mat Martineau <martineau@...nel.org>
Cc: Geliang Tang <geliang@...nel.org>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Donald Hunter <donald.hunter@...il.com>, Davide Caratti
<dcaratti@...hat.com>, netdev@...r.kernel.org, mptcp@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] netlink: specs: mptcp: fix port endianness
Hi Asbjørn,
On 11/09/2024 11:10, Asbjørn Sloth Tønnesen wrote:
> The MPTCP port attribute is in host endianness, but was documented
> as big-endian in the ynl specification.
>
> Below are two examples from net/mptcp/pm_netlink.c showing that the
> attribute is converted to/from host endianness for use with netlink.
>
> Import from netlink:
> addr->port = htons(nla_get_u16(tb[MPTCP_PM_ADDR_ATTR_PORT]))
>
> Export to netlink:
> nla_put_u16(skb, MPTCP_PM_ADDR_ATTR_PORT, ntohs(addr->port))
>
> Where addr->port is defined as __be16.
>
> No functional change intended.
Good catch. Indeed, this port attribute is supposed to be in host
endianness.
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
This patch can be applied in netdev directly.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
Powered by blists - more mailing lists