netdev - Re: [PATCH net v2 1/2] bareudp: Pull inner IP header in bareudp_udp_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66e1ba805f3ed_117c772947d@willemb.c.googlers.com.notmuch>
Date: Wed, 11 Sep 2024 11:42:56 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Guillaume Nault <gnault@...hat.com>, 
 David Miller <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, 
 Martin Varghese <martin.varghese@...ia.com>, 
 Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v2 1/2] bareudp: Pull inner IP header in
 bareudp_udp_encap_recv().

Guillaume Nault wrote:
> Bareudp reads the inner IP header to get the ECN value. Therefore, it
> needs to ensure that it's part of the skb's linear data.
> 
> This is similar to the vxlan and geneve fixes for that same problem:
>   * commit f7789419137b ("vxlan: Pull inner IP header in vxlan_rcv().")
>   * commit 1ca1ba465e55 ("geneve: make sure to pull inner header in
>     geneve_rx()")
> 
> Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.")
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>