netdev - Re: [PATCH net-next] net/smc: add sysctl for smc_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <763f0662-c001-4bce-accf-1d7cf2fbaf60@linux.alibaba.com>
Date: Wed, 11 Sep 2024 10:53:42 +0800
From: "D. Wythe" <alibuda@...ux.alibaba.com>
To: Paolo Abeni <pabeni@...hat.com>, kgraul@...ux.ibm.com,
 wenjia@...ux.ibm.com, jaka@...ux.ibm.com, wintera@...ux.ibm.com,
 guwen@...ux.alibaba.com
Cc: kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
 linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org,
 tonylu@...ux.alibaba.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] net/smc: add sysctl for smc_limit_hs

On 9/10/24 6:10 PM, Paolo Abeni wrote:
> On 9/6/24 04:35, D. Wythe wrote:
>> From: "D. Wythe" <alibuda@...ux.alibaba.com>
>>
>> In commit 48b6190a0042 ("net/smc: Limit SMC visits when handshake 
>> workqueue congested"),
>> we introduce a mechanism to put constraint on SMC connections visit
>> according to the pressure of SMC handshake process.
>>
>> At that time, we believed that controlling the feature through netlink
>> was sufficient. However, most people have realized now that netlink is
>> not convenient in container scenarios, and sysctl is a more suitable
>> approach.
>
> Not blocking this patch, but could you please describe why/how NL is 
> less convenient? is possibly just a matter of lack of command line 
> tool to operate on NL? yaml to the rescue ;)
>
> Cheers,
>
> Paolo

Hi Paolo,

Based on the information I've gathered, there are several aspects:

1. There is a lack of support for YAML on NL in popular products.

2. The infrastructure related to NLwas not yet sound enough. For 
example, how to disable
settings for certain NL in container, while we can do it within sysctls. 
Also, regular synchronization.
NL may be able to implement it (maybe via Yaml ), but it still be waiting
for support in popular products.

Best wishes,
D. Wythe