netdev - Re: [PATCH net] net: dsa: lan9303: avoid dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b9dc2a2494c2af62cd37e506bbad73a44819c36.camel@siemens.com>
Date: Wed, 11 Sep 2024 17:09:08 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "olteanv@...il.com" <olteanv@...il.com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "f.fainelli@...il.com" <f.fainelli@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: lan9303: avoid dsa_switch_shutdown()

On Wed, 2024-09-11 at 19:04 +0200, Alexander Sverdlin wrote:
> > > The difference between that and this is the extra lan9303_disable_processing_port()
> > > calls here. But while that does disable RX on switch ports, it still doesn't wait
> > > for pending RX frames to be processed. So the race is still open. No?
> 
> besides from the below, I've expected this question... In the meanwhile I've tested
> mv88e6xxx driver, but it (accidentally) has no MDIO race vs shutdown.
> After some shallow review of the drivers I didn't find dev_get_drvdata <= mdio_read
> pattern therefore I've posted this tested patch.
> 
> If you'd prefer to solve this centrally for all drivers, I can test your patch from
> the MDIO-drvdata PoV.

But this would mean throwing away the whole
"net: dsa: be compatible with masters which unregister on shutdown" work?

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com