netdev - [PATCH net-next 2/5] net: phy: aquantia: allow firmware loading after aqr_wait_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <trinity-ddc3de71-4149-43ad-8e8c-99edf092a769-1726082664469@3c-app-gmx-bs04>
Date: Wed, 11 Sep 2024 21:24:24 +0200
From: Hans-Frieder Vogt <hfdevel@....net>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, FUJITA Tomonori
 <fujita.tomonori@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
Subject: [PATCH net-next 2/5] net: phy: aquantia: allow firmware loading
 after aqr_wait_reset_complete

Allow firmware loading from nvmem or fs. As discussed in
https://lore.kernel.org/netdev/20240806112747.soclko5vex2f2c64@skbuf/ the
return value -ETIMEDOUT (returned by aqr_wait_reset_complete when the
firmware version is still 0 after 2s) needs to be let through. Otherwise,
this will prevent loading of an external firmware.

Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
---
 drivers/net/phy/aquantia/aquantia_firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/aquantia/aquantia_firmware.c b/drivers/net/phy/aquantia/aquantia_firmware.c
index 524627a36c6f..090fcc9a3413 100644
--- a/drivers/net/phy/aquantia/aquantia_firmware.c
+++ b/drivers/net/phy/aquantia/aquantia_firmware.c
@@ -354,7 +354,7 @@ int aqr_firmware_load(struct phy_device *phydev)
 	int ret;

 	ret = aqr_wait_reset_complete(phydev);
-	if (ret)
+	if (ret != -ETIMEDOUT)
 		return ret;

 	/* Check if the firmware is not already loaded by pooling
--
2.45.2