netdev - Re: [PATCH 05/21] ntp: Convert functions with only two states to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCpnBMZkp9TUca8OEYKS=ECE516Y9DMy28SrcAstYB0iqg@mail.gmail.com>
Date: Wed, 11 Sep 2024 13:12:05 -0700
From: John Stultz <jstultz@...gle.com>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: Frederic Weisbecker <frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	Miroslav Lichvar <mlichvar@...hat.com>, Richard Cochran <richardcochran@...il.com>, 
	Christopher S Hall <christopher.s.hall@...el.com>
Subject: Re: [PATCH 05/21] ntp: Convert functions with only two states to bool

On Wed, Sep 11, 2024 at 6:18 AM Anna-Maria Behnsen
<anna-maria@...utronix.de> wrote:
>
> From: Thomas Gleixner <tglx@...utronix.de>
>
> is_error_status() and ntp_synced() return whether a state is set or
> not. Both functions use unsigned int for it even if it would be a perfect
> job for a bool.
>
> Use bool instead of unsigned int. And while at it, move ntp_synced()
> function to the place where it is used.
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

Acked-by: John Stultz <jstultz@...gle.com>

thanks
-john