lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ikv1bz8e.fsf@kernel.org>
Date: Thu, 12 Sep 2024 01:29:53 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,  linux-wireless@...r.kernel.org
Subject: Re: pull-request: wireless-next-2024-09-11

Jakub Kicinski <kuba@...nel.org> writes:

> On Wed, 11 Sep 2024 08:41:47 +0000 (UTC) Kalle Valo wrote:
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> For a follow up, clang W=1 says:
>
> ../drivers/net/wireless/realtek/rtw89/coex.c:6323:23: warning:
> variable 'cnt_2g' set but not used [-Wunused-but-set-variable]
>  6323 |         u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc;
>       |                              ^
> ../drivers/net/wireless/realtek/rtw89/coex.c:6323:35: warning:
> variable 'cnt_5g' set but not used [-Wunused-but-set-variable]
>  6323 |         u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc;
>       |                                          ^
> 2 warnings generated.
> ../drivers/staging/rtl8712/rtl8712_recv.c:139:6: warning: variable
> 'drvinfo_sz' set but not used [-Wunused-but-set-variable]
>   139 |         u16 drvinfo_sz;
>       |             ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable
> 'efuseValue' set but not used [-Wunused-but-set-variable]
>   285 |         u32 efuseValue;
>       |             ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_recv.c:2030:7: warning: variable
> 'cnt' set but not used [-Wunused-but-set-variable]
>  2030 |                 int cnt = 0;
>       |                     ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:288:6: warning:
> variable 'poll_cnt' set but not used [-Wunused-but-set-variable]
>   288 |                 u8 poll_cnt = 0;
>       |                    ^

What's the deadline for these? Do you need the fixes tomorrow or can it
wait a week or two?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ