netdev - Re: [PATCH net-next 4/5] net: integrate QUIC build configuration into Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240911170048.4f6d5bd9@kernel.org>
Date: Wed, 11 Sep 2024 17:00:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Moritz Buhl <mbuhl@...nbsd.org>, Tyler Fanelli
 <tfanelli@...hat.com>, Pengtao He <hepengtao@...omi.com>,
 linux-cifs@...r.kernel.org, Steve French <smfrench@...il.com>, Namjae Jeon
 <linkinjeon@...nel.org>, Stefan Metzmacher <metze@...ba.org>, Paulo
 Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>,
 kernel-tls-handshake@...ts.linux.dev, Chuck Lever <chuck.lever@...cle.com>,
 Jeff Layton <jlayton@...nel.org>, Steve Dickson <steved@...hat.com>, Hannes
 Reinecke <hare@...e.de>, Alexander Aring <aahringo@...hat.com>, Sabrina
 Dubroca <sd@...asysnail.net>, Marcelo Ricardo Leitner
 <marcelo.leitner@...il.com>, Daniel Stenberg <daniel@...x.se>, Andy
 Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next 4/5] net: integrate QUIC build configuration
 into Kconfig and Makefile

On Mon,  9 Sep 2024 22:30:19 -0400 Xin Long wrote:
> This commit introduces build configurations for QUIC within the networking
> subsystem. The Kconfig and Makefile files in the net directory are updated
> to include options and rules necessary for building QUIC protocol support.

Don't split out trivial config changes like this, what's the point.
It just make build testing harder.

Speaking of which, it doesn't build on 32bit:

ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined!
ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined!
ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined!

If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf
we won't have enough time to review for 6.12 even if Linus cuts -rc8.
-- 
pw-bot: cr