netdev - Re: [PATCH net-next v2 1/4] bnxt_en: add support for rx-copybreak ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimx-R5OV-3=oZkVBTtyN8jhR7w_YW6VVu6EA7D8vSWHRg@mail.gmail.com>
Date: Wed, 11 Sep 2024 17:47:01 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Taehee Yoo <ap420073@...il.com>, Brett Creeley <bcreeley@....com>, davem@...emloft.net, 
	pabeni@...hat.com, edumazet@...gle.com, corbet@....net, 
	netdev@...r.kernel.org, linux-doc@...r.kernel.org, ecree.xilinx@...il.com, 
	przemyslaw.kitszel@...el.com, andrew@...n.ch, hkallweit1@...il.com, 
	kory.maincent@...tlin.com, ahmed.zaki@...el.com, paul.greenwalt@...el.com, 
	rrameshbabu@...dia.com, idosch@...dia.com, maxime.chevallier@...tlin.com, 
	danieller@...dia.com, aleksander.lobakin@...el.com, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v2 1/4] bnxt_en: add support for rx-copybreak
 ethtool command

On Wed, Sep 11, 2024 at 5:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 12 Sep 2024 00:53:31 +0900 Taehee Yoo wrote:
> > > if (netif_running(dev)) {
> > > bnxt_close_nic(bp, false, false);
> > > bp->rx_copybreak = rx_copybreak;
> > > bnxt_set_ring_params(bp);
> > > bnxt_open_nic(bp, false, false);
> > > } else {
> > > bp->rx_copybreak = rx_copybreak;
> > > }
> >
> > I think your suggestion is much safer!
> > I will use your suggestion in the v3 patch.
>
> This is better but Andy mentioned on another thread that queue reset
> should work, so instead of full close / open maybe we can just do:
>
>         for (/* all Rx queues */) {
>                 bnxt_queue_stop();
>                 bnxt_queue_start();
>         }
>
> when the device is already running?

If the copybreak value changes, I don't think queue restart will work.
We need to size and allocate the buffers differently than before, so I
think we need to do close/open.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)