netdev - [PATCH net-next v3 0/4] enic: Report per queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240912005039.10797-1-neescoba@cisco.com>
Date: Wed, 11 Sep 2024 17:50:35 -0700
From: Nelson Escobar <neescoba@...co.com>
To: netdev@...r.kernel.org
Cc: satishkh@...co.com, johndale@...co.com,
        Nelson Escobar <neescoba@...co.com>
Subject: [PATCH net-next v3 0/4] enic: Report per queue stats

Hi,

This is V3 of a series that adds per queue stats report to enic driver.
Per Jakub's suggestion, I've removed the stats present in qstats from the
ethtool output.

Patch #1: Use a macro instead of static const variables for array sizes.  I
          didn't want to add more static const variables in the next patch
          so clean up the existing ones first.

Patch #2: Collect per queue statistics

Patch #3: Report per queue stats in netdev qstats

Patch #4: Report some per queue stats in ethtool

# NETIF="eno6" tools/testing/selftests/drivers/net/stats.py
KTAP version 1
1..5
ok 1 stats.check_pause # XFAIL pause not supported by the device
ok 2 stats.check_fec # XFAIL FEC not supported by the device
ok 3 stats.pkt_byte_sum
ok 4 stats.qstat_by_ifindex
ok 5 stats.check_down
# Totals: pass:3 fail:0 xfail:2 xpass:0 skip:0 error:0

# tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml --dump qstats-get --json '{"ifindex": "34"}'
[{'ifindex': 34,
  'rx-bytes': 66762680,
  'rx-csum-unnecessary': 1009345,
  'rx-hw-drop-overruns': 0,
  'rx-hw-drops': 0,
  'rx-packets': 1009673,
  'tx-bytes': 137936674899,
  'tx-csum-none': 125,
  'tx-hw-gso-packets': 2408712,
  'tx-needs-csum': 2431531,
  'tx-packets': 15475466,
  'tx-stop': 0,
  'tx-wake': 0}]

---

V3:
  - Added a few more stats to be reported in netdev qstats
  - Removed stats reported in netdev qstats from the ethtool output per
    Jakub's suggestion
  - Patch order changes and commit message change to better reflect that
    ethtool patch only contains stats not in netdev qstats
  - Some minor changes like renaming the 'csum' counter to 'csum_none' and
    changes to counter comments to make things a little clearer
v2: https://lore.kernel.org/all/20240905010900.24152-1-neescoba@cisco.com/
  - Split the ethtool stats reporting into its own patch
  - Added a patch for reporting stats with netdev qstats per Jakub's
    suggestion
v1: https://lore.kernel.org/all/20240823235401.29996-1-neescoba@cisco.com/


Nelson Escobar (4):
  enic: Use macro instead of static const variables for array sizes
  enic: Collect per queue statistics
  enic: Report per queue statistics in netdev qstats
  enic: Report some per queue statistics in ethtool

 drivers/net/ethernet/cisco/enic/enic.h        |  38 ++++-
 .../net/ethernet/cisco/enic/enic_ethtool.c    | 102 ++++++++++--
 drivers/net/ethernet/cisco/enic/enic_main.c   | 157 ++++++++++++++++--
 3 files changed, 269 insertions(+), 28 deletions(-)

-- 
2.35.2