netdev - Re: [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two imports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed54ad21-4a5b-4bbb-8f16-22fbfe1bd738@kernel.org>
Date: Thu, 12 Sep 2024 13:22:58 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, ncardwell@...gle.com, shuah@...nel.org,
 linux-kselftest@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two
 imports

Hi Willem,

On 12/09/2024 02:52, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> 1/3: run in nets, as discussed, and add missing CONFIGs
> 2/3: import tcp/zerocopy
> 3/3: import tcp/slow_start

Thank you for the v2. This new version looks good to me:

Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>


I didn't pay too much attention to the new tests, because they look
good, heavily tested I suppose, and I guess the goal is not to diverge
from the original ones for the moment. Still, please note that the CI
reported some timing issues with tcp_zerocopy_closed.pkt when using a
debug kernel config, e.g.

> tcp_zerocopy_closed.pkt:22: timing error: expected system call return at 0.100596 sec but happened at 0.109564 sec; tolerance 0.004000 sec

https://netdev.bots.linux.dev/contest.html?executor=vmksft-packetdrill-dbg&test=tcp-zerocopy-closed-pkt

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.