netdev - Re: [net-next 06/15] net/mlx5: fs, remove unused member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4fe6053-0389-437c-aad1-f0004752e154@intel.com>
Date: Thu, 12 Sep 2024 12:06:56 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Saeed Mahameed <saeed@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
CC: Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan
	<tariqt@...dia.com>, Gal Pressman <gal@...dia.com>, Leon Romanovsky
	<leonro@...dia.com>, Mark Bloch <mbloch@...dia.com>
Subject: Re: [net-next 06/15] net/mlx5: fs, remove unused member



On 9/11/2024 1:17 PM, Saeed Mahameed wrote:
> From: Mark Bloch <mbloch@...dia.com>
> 
> Counter is in struct fte, remove it.
> 
> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> index 6201647d6156..5eacf64232f7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> @@ -241,7 +241,6 @@ struct fs_fte {
>  	struct mlx5_flow_context	flow_context;
>  	struct mlx5_flow_act		action;
>  	enum fs_fte_status		status;
> -	struct mlx5_fc			*counter;
>  	struct rhash_head		hash;

It looks like this was added by commit bd5251dbf156 ("net/mlx5_core:
Introduce flow steering destination of type counter") and never directly
used. The pointer appears to also be stored in the mlx5_flow_destination
which is the only place it was directly used.

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  	int				modify_mask;
>  };