netdev - Re: [PATCH net-next 3/5] net: phy: aquantia: search for firmware-name in fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d5a5cbb-c13f-4354-a48a-d20cb5a2def3@lunn.ch>
Date: Thu, 12 Sep 2024 21:15:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Hans-Frieder Vogt <hfdevel@....net>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/5] net: phy: aquantia: search for
 firmware-name in fwnode

> device_property_read_string() would would be very elegant, but it only
> looks for properties in the swnode of this device.
> However, I did not find a way to add a swnode directly to the phy, but
> only to the mdiobus.

Think about the DT representation, taken from marvell,aquantia.yaml.

    mdio {
        #address-cells = <1>;
        #size-cells = <0>;

        ethernet-phy@0 {
            compatible = "ethernet-phy-id31c3.1c12",
                         "ethernet-phy-ieee802.3-c45";

            reg = <0>;
            firmware-name = "AQR-G4_v5.4.C-AQR_CIG_WF-1945_0x8_ID44776_VER1630.cld";
        };

        ethernet-phy@1 {
            compatible = "ethernet-phy-id31c3.1c12",
                         "ethernet-phy-ieee802.3-c45";

            reg = <1>;
            nvmem-cells = <&aqr_fw>;
            nvmem-cell-names = "firmware";
        };
    };

You want to construct the same. Do you know the address on the bus the
PHY uses? Can you create a ethernet-phy@X node? And then put the
property there?

Then there is the question of if the current code associates the
swnode to the PHY device. I've no idea if it does! If not, it might
mean we need to add a device_set_node(&mdiodev->dev, fwnode) somewhere
in the core code.

       Andrew