netdev - Re: [PATCH net-next 01/13] selftests: ncdevmem: Add a flag for the selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izNzP_-CS2FyuUo6xRzumMAFRbkE00DOzmHpjBSkMUP3PA@mail.gmail.com>
Date: Thu, 12 Sep 2024 13:36:39 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next 01/13] selftests: ncdevmem: Add a flag for the selftest

On Thu, Sep 12, 2024 at 10:12 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> And rename it to 'probing'. This is gonna be used in the selftests
> to probe devmem functionality.
>
> Cc: Mina Almasry <almasrymina@...gle.com>
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> ---
>  tools/testing/selftests/net/ncdevmem.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c
> index 64d6805381c5..352dba211fb0 100644
> --- a/tools/testing/selftests/net/ncdevmem.c
> +++ b/tools/testing/selftests/net/ncdevmem.c
> @@ -523,8 +523,9 @@ void run_devmem_tests(void)
>  int main(int argc, char *argv[])
>  {
>         int is_server = 0, opt;
> +       int probe = 0;
>
> -       while ((opt = getopt(argc, argv, "ls:c:p:v:q:t:f:")) != -1) {
> +       while ((opt = getopt(argc, argv, "ls:c:p:v:q:t:f:P")) != -1) {
>                 switch (opt) {
>                 case 'l':
>                         is_server = 1;
> @@ -550,6 +551,9 @@ int main(int argc, char *argv[])
>                 case 'f':
>                         ifname = optarg;
>                         break;
> +               case 'P':
> +                       probe = 1;
> +                       break;
>                 case '?':
>                         printf("unknown option: %c\n", optopt);
>                         break;
> @@ -561,7 +565,10 @@ int main(int argc, char *argv[])
>         for (; optind < argc; optind++)
>                 printf("extra arguments: %s\n", argv[optind]);
>
> -       run_devmem_tests();
> +       if (probe) {
> +               run_devmem_tests();
> +               return 0;
> +       }
>

Before this change:
./ncdevmem (runs run_devmem_tests() and exits)
./ncdevmem -l: runs devmem tests and listens

And I plan to add, for the tx path:

./ncdevmem -c: runs devmem tests and does a devmem client.

After this change, running ncdevmem with no flags just exits without
doing anything; a bit weird IMO, but I'm not opposed if you see an
upside.

Is your intention with this change to not run the devmem tests on
listen? Maybe something like:

if (is_server)
  return do_server();
else if (is_client) /* to be added */
  return do_client();
else
  run_devmem_tests();

return 0;

?

But, I'm not totally opposed if you see an upside. Maybe use -p
instead of -P for consistency.



--
Thanks,
Mina