netdev - Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26a35c93-5a59-4ca1-ba62-01258767b214@linux.dev>
Date: Thu, 12 Sep 2024 23:16:55 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Brett Creeley <brett.creeley@....com>, alexanderduyck@...com,
 kuba@...nel.org, kernel-team@...a.com, davem@...emloft.net,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: jdamato@...tly.com, stable@...r.kernel.org
Subject: Re: [PATCH net] fbnic: Set napi irq value after calling
 netif_napi_add

On 12/09/2024 18:49, Brett Creeley wrote:
> The driver calls netif_napi_set_irq() and then calls netif_napi_add(),
> which calls netif_napi_add_weight(). At the end of
> netif_napi_add_weight() is a call to netif_napi_set_irq(napi, -1), which
> clears the previously set napi->irq value. Fix this by calling
> netif_napi_set_irq() after calling netif_napi_add().
> 
> This was found when reviewing another patch and I have no way to test
> this, but the fix seemed relatively straight forward.
> Cc: stable@...r.kernel.org
> Fixes: bc6107771bb4 ("eth: fbnic: Allocate a netdevice and napi vectors with queues")
> Signed-off-by: Brett Creeley <brett.creeley@....com>

I agree that irq vector is lost without this patch.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>