netdev - [PATCH ethtool 2/2] qsf: Better handling of Page A2h netlink read failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <54419258-fa69-447b-9e3f-35accf891d43@ans.pl>
Date: Wed, 11 Sep 2024 23:58:42 -0700
From: Krzysztof Olędzki <ole@....pl>
To: Ido Schimmel <idosch@...dia.com>, Andrew Lunn <andrew@...n.ch>,
        Michal Kubecek <mkubecek@...e.cz>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH ethtool 2/2] qsf: Better handling of Page A2h netlink read
 failure

Print "Failed to read Page A2h." error message to provide more context
for "netlink error: (...)" info.

Signed-off-by: Krzysztof Piotr Oledzki <ole@....pl>
---
 sfpid.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sfpid.c b/sfpid.c
index 1bc45c1..d9bda70 100644
--- a/sfpid.c
+++ b/sfpid.c
@@ -494,8 +494,10 @@ int sff8079_show_all_nl(struct cmd_context *ctx)
 	/* Read A2h page */
 	ret = sff8079_get_eeprom_page(ctx, SFF8079_I2C_ADDRESS_HIGH,
 				      buf + ETH_MODULE_SFF_8079_LEN);
-	if (ret)
+	if (ret) {
+		fprintf(stderr, "Failed to read Page A2h.\n");
 		goto out;
+	}
 
 	sff8472_show_all(buf);
 out:
-- 
2.46.0