[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CALOAHbCRnqg8q-9KxNHZVfGUm5aO5_60X_sZB7TPB68EMz7mZA@mail.gmail.com>
Date: Fri, 13 Sep 2024 10:23:17 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: Justin Stitt <justinstitt@...gle.com>
Cc: akpm@...ux-foundation.org, torvalds@...ux-foundation.org, alx@...nel.org,
ebiederm@...ssion.com, alexei.starovoitov@...il.com, rostedt@...dmis.org,
catalin.marinas@....com, penguin-kernel@...ove.sakura.ne.jp,
linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, audit@...r.kernel.org,
linux-security-module@...r.kernel.org, selinux@...r.kernel.org,
bpf@...r.kernel.org, netdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
Daniel Vetter <daniel.vetter@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>
Subject: Re: [PATCH v8 8/8] drm: Replace strcpy() with strscpy()
On Fri, Sep 13, 2024 at 5:28 AM Justin Stitt <justinstitt@...gle.com> wrote:
>
> Hi,
>
> On Wed, Aug 28, 2024 at 11:03:21AM GMT, Yafang Shao wrote:
> > To prevent erros from occurring when the src string is longer than the
> > dst string in strcpy(), we should use strscpy() instead. This
> > approach also facilitates future extensions to the task comm.
> >
> > Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> > Acked-by: Daniel Vetter <daniel.vetter@...ll.ch>
> > Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> > Cc: Maxime Ripard <mripard@...nel.org>
> > Cc: Thomas Zimmermann <tzimmermann@...e.de>
> > Cc: David Airlie <airlied@...il.com>
> > ---
> > drivers/gpu/drm/drm_framebuffer.c | 2 +-
> > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
> > index 888aadb6a4ac..2d6993539474 100644
> > --- a/drivers/gpu/drm/drm_framebuffer.c
> > +++ b/drivers/gpu/drm/drm_framebuffer.c
> > @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb,
> > INIT_LIST_HEAD(&fb->filp_head);
> >
> > fb->funcs = funcs;
> > - strcpy(fb->comm, current->comm);
> > + strscpy(fb->comm, current->comm);
> >
> > ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB,
> > false, drm_framebuffer_free);
> > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>
> There are other strcpy() in this file but it seems all control paths to
> the copies themselves stem from string literals, so it is probably fine
> not to also change those ones. But, if a v9 is required and you're
> feeling up to it, we should probably replace them too, as per [1].
will change them in the next version.
Thanks for your suggestion.
>
>
> > index 96c6cafd5b9e..afa9dae39378 100644
> > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > @@ -1412,7 +1412,7 @@ static bool record_context(struct i915_gem_context_coredump *e,
> > rcu_read_lock();
> > task = pid_task(ctx->pid, PIDTYPE_PID);
> > if (task) {
> > - strcpy(e->comm, task->comm);
> > + strscpy(e->comm, task->comm);
> > e->pid = task->pid;
> > }
> > rcu_read_unlock();
> > --
> > 2.43.5
> >
> >
>
>
> Reviewed-by: Justin Stitt <justinstitt@...gle.com>
>
> [1]: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
>
> Thanks
> Justin
--
Regards
Yafang
Powered by blists - more mailing lists