netdev - Re: linux-next: build failure after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240913113619.4bf2bf16@kernel.org>
Date: Fri, 13 Sep 2024 11:36:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>, Stephen Rothwell
 <sfr@...b.auug.org.au>
Cc: christophe.leroy2@...soprasteria.com, David Miller
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Networking
 <netdev@...r.kernel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: linux-next: build failure after merge of the net-next tree

On Fri, 13 Sep 2024 09:27:17 -0700 Mina Almasry wrote:
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 5769fe6e4950..ea4005d2d1a9 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -239,8 +239,8 @@ static inline unsigned long _compound_head(const
> struct page *page)
>  {
>         unsigned long head = READ_ONCE(page->compound_head);
> 
> -       if (unlikely(head & 1))
> -               return head - 1;
> +       if (unlikely(head & 1UL))
> +               return head & ~1UL;
>         return (unsigned long)page_fixed_fake_head(page);
>  }
> 
> Other than that I think this is a correct fix. Jakub, what to do here.
> Do I send this fix to the mm tree or to net-next?

Yes, please, send this out and CC all the relevant people.
We can decide which tree it will go into once its reviewed.

Stephen, would you be willing to slap this on top of linux-next for now?
I can't think of a better bandaid we could put in net-next,
and it'd be sad to revert a major feature because of a compiler bug(?)