netdev - Re: [PATCH net-next v1] mm: fix build on powerpc with GCC 14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuSQ9BT9Vg7O2kXv@casper.infradead.org>
Date: Fri, 13 Sep 2024 20:22:28 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Simon Horman <horms@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
	Linux Next Mailing List <linux-next@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	LEROY Christophe <christophe.leroy2@...soprasteria.com>
Subject: Re: [PATCH net-next v1] mm: fix build on powerpc with GCC 14

On Fri, Sep 13, 2024 at 07:20:36PM +0000, Mina Almasry wrote:
> +++ b/include/linux/page-flags.h
> @@ -239,8 +239,8 @@ static inline unsigned long _compound_head(const struct page *page)
>  {
>  	unsigned long head = READ_ONCE(page->compound_head);
>  
> -	if (unlikely(head & 1))
> -		return head - 1;
> +	if (unlikely(head & 1UL))
> +		return head & ~1UL;
>  	return (unsigned long)page_fixed_fake_head(page);

NAK, that pessimises compound_head().