[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <28d0a7a5-ead6-4ce0-801c-096038823259@lunn.ch>
Date: Fri, 13 Sep 2024 21:27:23 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <olteanv@...il.com>
Cc: "A. Sverdlin" <alexander.sverdlin@...mens.com>, netdev@...r.kernel.org,
Ar1nç ÜNAL <arinc.unal@...nc9.com>,
Daniel Golle <daniel@...rotopia.org>,
DENG Qingfang <dqfext@...il.com>,
Sean Wang <sean.wang@...iatek.com>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Claudiu Manoil <claudiu.manoil@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
UNGLinuxDriver@...rochip.com,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>,
Mark Lee <Mark-MC.Lee@...iatek.com>,
Roopa Prabhu <roopa@...dia.com>,
Nikolay Aleksandrov <razor@...ckwall.org>,
linux-mediatek@...ts.infradead.org, bridge@...ts.linux.dev,
stable@...r.kernel.org
Subject: Re: [PATCH 1/2] net: dsa: RCU-protect dsa_ptr in struct net_device
> > drivers/net/dsa/mt7530.c | 3 +-
> > drivers/net/dsa/ocelot/felix.c | 3 +-
> > drivers/net/dsa/qca/qca8k-8xxx.c | 3 +-
> > drivers/net/ethernet/broadcom/bcmsysport.c | 8 +-
> > drivers/net/ethernet/mediatek/airoha_eth.c | 2 +-
> > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 22 +++--
> > drivers/net/ethernet/mediatek/mtk_ppe.c | 15 ++-
> > include/linux/netdevice.h | 2 +-
> > include/net/dsa.h | 36 +++++--
> > include/net/dsa_stubs.h | 6 +-
> > net/bridge/br_input.c | 2 +-
> > net/core/dev.c | 3 +-
> > net/core/flow_dissector.c | 19 ++--
> > net/dsa/conduit.c | 66 ++++++++-----
> > net/dsa/dsa.c | 19 ++--
> > net/dsa/port.c | 3 +-
> > net/dsa/tag.c | 3 +-
> > net/dsa/tag.h | 19 ++--
> > net/dsa/tag_8021q.c | 10 +-
> > net/dsa/tag_brcm.c | 2 +-
> > net/dsa/tag_dsa.c | 8 +-
> > net/dsa/tag_qca.c | 10 +-
> > net/dsa/tag_sja1105.c | 22 +++--
> > net/dsa/user.c | 104 +++++++++++---------
> > net/ethernet/eth.c | 2 +-
> > 25 files changed, 240 insertions(+), 152 deletions(-)
>
> Thank you for the patch, and I would like you to not give up on it, even
> if we will go for a different bug fix for 'stable'.
>
> It's just that it makes me a bit uneasy to have this as the bug fix.
+1
We should try for a minimal fix for stable, and keep this for
net-next, given its size.
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
* It must be obviously correct and tested.
* It cannot be bigger than 100 lines, with context.
Andrew
Powered by blists - more mailing lists