netdev - Re: [PATCH -next v4 1/2] posix-clock: Check timespec64 before call clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914152318.GC11774@kernel.org>
Date: Sat, 14 Sep 2024 16:23:18 +0100
From: Simon Horman <horms@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: bryan.whitehead@...rochip.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, anna-maria@...utronix.de,
	frederic@...nel.org, tglx@...utronix.de, richardcochran@...il.com,
	UNGLinuxDriver@...rochip.com, mbenes@...e.cz, jstultz@...gle.com,
	andrew@...n.ch, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v4 1/2] posix-clock: Check timespec64 before call
 clock_settime()

On Sat, Sep 14, 2024 at 06:06:24PM +0800, Jinjie Ruan wrote:
> As Andrew pointed out, it will make sense that the PTP core
> checked timespec64 struct's tv_sec and tv_nsec range before calling
> ptp->info->settime64().
> 
> As the man mannul of clock_settime() said, if tp.tv_sec is negative or
> tp.tv_nsec is outside the range [0..999,999,999], it shuld return EINVAL,

nit: should

Flagged by checkpatch.pl --codespell

...