[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240914071254.7b376031@kernel.org>
Date: Sat, 14 Sep 2024 07:12:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Su Hui <suhui@...china.com>
Cc: jmaloy@...hat.com, ying.xue@...driver.com, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com, nathan@...nel.org,
ndesaulniers@...gle.com, morbo@...gle.com, justinstitt@...gle.com,
horms@...nel.org, dan.carpenter@...aro.org, tuong.t.lien@...tech.com.au,
netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net v2] net: tipc: avoid possible garbage value
On Sat, 14 Sep 2024 18:26:21 +0800 Su Hui wrote:
> Clang static checker (scan-build) warning:
> net/tipc/bcast.c:305:4:
> The expression is an uninitialized value. The computed value will also
> be garbage [core.uninitialized.Assign]
> 305 | (*cong_link_cnt)++;
> | ^~~~~~~~~~~~~~~~~~
>
> tipc_rcast_xmit() will increase cong_link_cnt's value, but cong_link_cnt
> is uninitialized. Although it won't really cause a problem, it's better
> to fix it.
>
> Fixes: dca4a17d24ee ("tipc: fix potential hanging after b/rcast changing")
> Signed-off-by: Su Hui <suhui@...china.com>
> Reviewed-by: Justin Stitt <justinstitt@...gle.com>
Applied, thanks:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=99655a304e450baaae6b396cb942b9e47659d644
--
pw-bot: accept
Powered by blists - more mailing lists