netdev - Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e999f47-b9e9-40e3-b6ac-538e06a63fc7@lunn.ch>
Date: Sat, 14 Sep 2024 16:39:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ronnie.Kunin@...rochip.com
Cc: Raju.Lakkaraju@...rochip.com, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, Bryan.Whitehead@...rochip.com,
	UNGLinuxDriver@...rochip.com, linux@...linux.org.uk,
	maxime.chevallier@...tlin.com, rdunlap@...radead.org,
	Steen.Hegelund@...rochip.com, Daniel.Machon@...rochip.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs

> As I have mentioned before I am not (and will likely never be) a
> Linux expert. I have just been advising Raju from the perspective of
> how the chip hardware works, the drivers I have written for it for a
> different OS, and what our customers have been requiring from us. I
> wasn't advocating against instantiating a second MDIO bus or
> whatever else makes sense in the Linux frameworks/environment,
> specially if the overhead to implement it is low and allows for
> richer or alternative use cases. I was just pointing out potential
> problems based on my knowledge of our hardware and the information I
> was told (now obviously misunderstood and/or incomplete) about these
> newer Linux frameworks (phylink, xpcs, sfp) by Raju / was
> understanding from your email.

Not a problem. That is partially why we do reviews, to make sure the
architecture is correct. And there is a tendency for developers and
drivers coming from other OSes to re-invent wheels, because some other
OSes do not provide those wheels. With Linux you have a bigger API to
understand, but less code to write.

	Andrew