netdev - Re: [PATCH] Fix misspelling of "accept*"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZucKZcwmd28S_t24@gallifrey>
Date: Sun, 15 Sep 2024 16:25:09 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Alexander Zubkov <green@...tor.net>, pabeni@...hat.com
Cc: linux-kernel@...r.kernel.org, linux-newbie@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix misspelling of "accept*"

* Alexander Zubkov (green@...tor.net) wrote:
> Hi,
> 
> I just wanted to kindly check in on the status of my patch. Please let
> me know if any further action is needed from my side.
> 
> Thanks for your time!

I was only a reviewer on this; it'll need some of the netdev people
to notice it for it to get further.

Dave

> Best regards,
> Alexander Zubkov
> 
> On Sat, Jun 22, 2024 at 10:14 PM Dr. David Alan Gilbert
> <linux@...blig.org> wrote:
> >
> > * Alexander Zubkov (green@...tor.net) wrote:
> > > Several files have "accept*" misspelled as "accpet*" in the comments.
> > > Fix all such occurrences.
> > >
> > > Signed-off-by: Alexander Zubkov <green@...tor.net>
> >
> > Reviewed-by: Dr. David Alan Gilbert <linux@...blig.org>
> >
> > hmm, should probably cc in some maintainers, I guess networking.
> > (added netdev and Paolo)
> >
> > Dave
> >
> > > ---
> > >  drivers/infiniband/hw/irdma/cm.c                              | 2 +-
> > >  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c | 4 ++--
> > >  drivers/net/ethernet/natsemi/ns83820.c                        | 2 +-
> > >  include/uapi/linux/udp.h                                      | 2 +-
> > >  4 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> > > index 36bb7e5ce..ce8d821bd 100644
> > > --- a/drivers/infiniband/hw/irdma/cm.c
> > > +++ b/drivers/infiniband/hw/irdma/cm.c
> > > @@ -3631,7 +3631,7 @@ void irdma_free_lsmm_rsrc(struct irdma_qp *iwqp)
> > >  /**
> > >   * irdma_accept - registered call for connection to be accepted
> > >   * @cm_id: cm information for passive connection
> > > - * @conn_param: accpet parameters
> > > + * @conn_param: accept parameters
> > >   */
> > >  int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
> > >  {
> > > diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > index 455a54708..96fd31d75 100644
> > > --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > @@ -342,8 +342,8 @@ static struct sk_buff *copy_gl_to_skb_pkt(const struct pkt_gl *gl,
> > >  {
> > >       struct sk_buff *skb;
> > >
> > > -     /* Allocate space for cpl_pass_accpet_req which will be synthesized by
> > > -      * driver. Once driver synthesizes cpl_pass_accpet_req the skb will go
> > > +     /* Allocate space for cpl_pass_accept_req which will be synthesized by
> > > +      * driver. Once driver synthesizes cpl_pass_accept_req the skb will go
> > >        * through the regular cpl_pass_accept_req processing in TOM.
> > >        */
> > >       skb = alloc_skb(gl->tot_len + sizeof(struct cpl_pass_accept_req)
> > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
> > > index 998586872..bea969dfa 100644
> > > --- a/drivers/net/ethernet/natsemi/ns83820.c
> > > +++ b/drivers/net/ethernet/natsemi/ns83820.c
> > > @@ -2090,7 +2090,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
> > >        */
> > >       /* Ramit : 1024 DMA is not a good idea, it ends up banging
> > >        * some DELL and COMPAQ SMP systems
> > > -      * Turn on ALP, only we are accpeting Jumbo Packets */
> > > +      * Turn on ALP, only we are accepting Jumbo Packets */
> > >       writel(RXCFG_AEP | RXCFG_ARP | RXCFG_AIRL | RXCFG_RX_FD
> > >               | RXCFG_STRIPCRC
> > >               //| RXCFG_ALP
> > > diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
> > > index 1a0fe8b15..d85d671de 100644
> > > --- a/include/uapi/linux/udp.h
> > > +++ b/include/uapi/linux/udp.h
> > > @@ -31,7 +31,7 @@ struct udphdr {
> > >  #define UDP_CORK     1       /* Never send partially complete segments */
> > >  #define UDP_ENCAP    100     /* Set the socket to accept encapsulated packets */
> > >  #define UDP_NO_CHECK6_TX 101 /* Disable sending checksum for UDP6X */
> > > -#define UDP_NO_CHECK6_RX 102 /* Disable accpeting checksum for UDP6 */
> > > +#define UDP_NO_CHECK6_RX 102 /* Disable accepting checksum for UDP6 */
> > >  #define UDP_SEGMENT  103     /* Set GSO segmentation size */
> > >  #define UDP_GRO              104     /* This socket can receive UDP GRO packets */
> > >
> > > --
> > > 2.45.2
> > >
> > >
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/