netdev - [PATCH net-next v2 0/7] net: tn40xx: add support for AQR105 based cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-602c050f-bc76-4557-9824-252b0de48659-1726429697171@3c-app-gmx-bap07>
Date: Sun, 15 Sep 2024 21:48:17 +0200
From: Hans-Frieder Vogt <hfdevel@....net>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, FUJITA Tomonori
 <fujita.tomonori@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet
 <edumazet@...gle.com>, Vladimir Oltean <vladimir.oltean@....com>
Subject: [PATCH net-next v2 0/7] net: tn40xx: add support for AQR105 based
 cards

This patch series adds support to the Tehuti tn40xx driver for TN9510 cards
which combine a TN4010 MAC with an Aquantia AQR105.
It is an update of the patch series "net: tn40xx: add support for AQR105 based cards",
https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/
addressing review comments and generally cleaning up the series.

With Vladimir Oltean having provided a patch to repair the logic of the waiting
time for firmware loading of the Aquantia PHYs and to avoid an error message
for an expected behavior
 (https://lore.kernel.org/netdev/20240913121230.2620122-1-vladimir.oltean@nxp.com/),
my little work around of the first patch series has been removed.
However, Vladimir's patch is a requirement for the loading of firmware from the
filesystem for Aquantia PHYs to work.

The patch was tested on a Tehuti TN9510 card (1fc9:4025:1fc9:3015).

Changes v1 -> v2:
- simplify the check for a firmware-name in a swnode in the aquantia PHY driver
  (comment from Andrew Lunn)
- changed the software node definition to an mdio node with phy child nodes, to
  be more in line with a typical device tree definition (also comment from
  Andrew Lunn)
  This also solves the problem with several TN4010-based cards that FUJITA
  Tomonori reported
- clarified the cleanup calls, now calling fwnode_handle_put instead of
  software_node_unregister (comment by FUJITA Tomonori)
- updated the function mdiobus_scan to support swnodes (following hint of
  Andrew Lunn)
- remove the small patch to avoid failing after aqr_wait_reset_complete, now
  that a proper patch by Vladimir Oltean is available
- replace setting of bit 3 in TN40_REG_MDIO_CMD_STAT by calling of
  tn40_mdio_set_speed (suggestion by FUJITA Tomonori)
- cleaning up the distributed calls to set the MDIO speed in the tn40xx driver
- define supported PCI-IDs including subvendor IDs to prevent loading on
  unsupported card

Hans-Frieder Vogt (7):
   net: phy: aquantia: add probe function to aqr105 for firmware loading
   net: phy: aquantia: search for firmware-name in fwnode
   net: phy: add swnode support to mdiobus_scan
   net: tn40xx: create a software node for mdio and phy and add to mdiobus
   net: tn40xx: prepare tn40xx driver to find phy of the TN9510 card
   net: tn40xx: optimize mdio speed settings
   net: tn40xx: add pci-id of the aqr105-based tehuti tn4010 cards

 drivers/net/ethernet/tehuti/tn40.c           |   15 ++++++
 drivers/net/ethernet/tehuti/tn40.h           |   30 +++++++++++
 drivers/net/ethernet/tehuti/tn40_mdio.c      |   69 ++++++++++++++++++++++++--
 drivers/net/phy/aquantia/aquantia_firmware.c |    6 ++
 drivers/net/phy/aquantia/aquantia_main.c     |    1
 drivers/net/phy/mdio_bus.c                   |   14 +++++
 6 files changed, 130 insertions(+), 5 deletions(-)