netdev - Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240916205246-5df7e565-6950-4503-ac4d-741c37b1afda@linutronix.de>
Date: Mon, 16 Sep 2024 20:54:21 +0200
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, 
	David Ahern <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Alexander Aring <alex.aring@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL

On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > only present when the dst cache is built.
> > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > options in the same file.
> > > 
> > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > Cc: stable@...r.kernel.org
> > > ---
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> > 
> > Reviewed-by: Simon Horman <horms@...nel.org>
> > Tested-by: Simon Horman <horms@...nel.org> # build-tested
> 
> Sorry Thomas, I missed one important thing:
> 
> Your Signed-off-by line needs to go above the scissors ('---')
> because when git applies your patch nothing below the scissors
> is included in the patch description.

Welp, this seems to be due to a combination of me forgetting to add it,
b4 adding it below the scissors automatically and then failing to warn
about the missing sign-off.

I'll resend v2 with your tags. And will also remove the Cc: stable as
per net rules.

Thanks!