netdev - RE: [PATCH iwl-net] ice: fix VLAN replay after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50896C07F6CD56B6D549BF40D6622@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Wed, 18 Sep 2024 20:39:37 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Ertman, David M" <david.m.ertman@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH iwl-net] ice: fix VLAN replay after reset



> -----Original Message-----
> From: Dave Ertman <david.m.ertman@...el.com>
> Sent: Wednesday, September 18, 2024 11:03 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [PATCH iwl-net] ice: fix VLAN replay after reset
> 
> There is a bug currently when there are more than one VLAN defined
> and any reset that affects the PF is initiated, after the reset rebuild
> no traffic will pass on any VLAN but the last one created.
> 
> This is caused by the iteration though the VLANs during replay each
> clearing the vsi_map bitmap of the VSI that is being replayed.  The
> problem is that during rhe replay, the pointer to the vsi_map bitmap
> is used by each successive vlan to determine if it should be replayed
> on this VSI.
> 
> The logic was that the replay of the VLAN would replace the bit in the map
> before the next VLAN would iterate through.  But, since the replay copies
> the old bitmap pointer to filt_replay_rules and creates a new one for the
> recreated VLANS, it does not do this, and leaves the old bitmap broken
> to be used to replay the remaining VLANs.
> 
> Since the old bitmap will be cleaned up in post replay cleanup, there is
> no need to alter it and break following VLAN replay, so don't clear the
> bit.
> 
> Fixes: 334cb0626de1 ("ice: Implement VSI replay framework")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>