netdev - Re: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dd8fada-0079-4429-89c0-4949302dbac4@lunn.ch>
Date: Wed, 18 Sep 2024 14:11:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Mohan.Prasad@...rochip.com
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com, shuah@...nel.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	horms@...nel.org, brett.creeley@....com, rosenp@...il.com,
	UNGLinuxDriver@...rochip.com, willemb@...gle.com
Subject: Re: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest
 file for basic tests of NIC

> > So i don't think this is a valid test. To really test autoneg off, you need to
> > configure both ends of the link.
> 
> I will change the implementation to configure both the ends of the link appropriately in the next version.

That would be good, but it does make the test and the test setup a lot
more complex. I would suggest keeping such two target tests
separate. Also, look to see if there are other such tests using two
targets, and keep the basic configuration the same, IP address
configuration, how to SSH between them etc. I'm not too familiar with
the test framework. Maybe this is all a solved problem and there are
helpers to use?

	Andrew