[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zurbw1-Fl0EfdC0l@smile.fi.intel.com>
Date: Wed, 18 Sep 2024 16:55:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: Simon Horman <horms@...nel.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Bill Wendling <morbo@...gle.com>,
Justin Stitt <justinstitt@...gle.com>,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
netdev@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH nf-next 0/2] netfilter: conntrack: label helpers
conditional compilation updates
On Wed, Sep 18, 2024 at 01:52:14PM +0200, Pablo Neira Ayuso wrote:
> On Mon, Sep 16, 2024 at 04:14:40PM +0100, Simon Horman wrote:
> > Hi,
> >
> > This short series updates conditional compilation of label helpers to:
> >
> > 1) Compile them regardless of if CONFIG_NF_CONNTRACK_LABELS is enabled
> > or not. It is safe to do so as the functions will always return 0 if
> > CONFIG_NF_CONNTRACK_LABELS is not enabled. And the compiler should
> > optimise waway the code. Which is the desired behaviour.
> >
> > 2) Only compile ctnetlink_label_size if CONFIG_NF_CONNTRACK_EVENTS is
> > enabled. This addresses a warning about this function being unused
> > in this case.
>
> Patch 1)
>
> -#ifdef CONFIG_NF_CONNTRACK_LABELS
> static inline int ctnetlink_label_size(const struct nf_conn *ct)
>
> Patch 2)
>
> +#ifdef CONFIG_NF_CONNTRACK_EVENTS
> static inline int ctnetlink_label_size(const struct nf_conn *ct)
>
> They both refer to ctnetlink_label_size(), #ifdef check is not
> correct.
But the first one touches more, no?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists