netdev - Re: [PATCH net v2] selftests: forwarding: Avoid false MDB delete/flush failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240919134159.GA1571683@kernel.org>
Date: Thu, 19 Sep 2024 14:41:59 +0100
From: Simon Horman <horms@...nel.org>
To: Jamie Bainbridge <jamie.bainbridge@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] selftests: forwarding: Avoid false MDB
 delete/flush failures

On Mon, Sep 16, 2024 at 07:49:05PM +1000, Jamie Bainbridge wrote:
> Running this test on a small system produces different failures every
> test checking deletions, and some flushes. From different test runs:
> 
> TEST: Common host entries configuration tests (L2)                [FAIL]
>   Failed to delete L2 host entry
> 
> TEST: Common port group entries configuration tests (IPv4 (S, G)) [FAIL]
>   IPv4 (S, G) entry with VLAN 10 not deleted when VLAN was not specified
> 
> TEST: Common port group entries configuration tests (IPv6 (*, G)) [FAIL]
>   IPv6 (*, G) entry with VLAN 10 not deleted when VLAN was not specified
> 
> TEST: Flush tests                                                 [FAIL]
>   Entry not flushed by specified VLAN ID
> 
> TEST: Flush tests                                                 [FAIL]
>   IPv6 host entry not flushed by "nopermanent" state
> 
> Add a short sleep after deletion and flush to resolve this.
> 
> Create a delay variable just for this test to allow short sleep, the
> lib.sh WAIT_TIME of 5 seconds makes the test far longer than necessary.
> 
> Tested on several weak systems with 0.1s delay:
> - Ivy Bridge Celeron netbook (2014 x86_64)
> - Raspberry Pi 3B (2016 aarch64)
> - Small KVM VM on Intel 10th gen (2020 x86_64)
> All these systems ran 25 test runs in a row with 100% pass OK.
> 
> Fixes: b6d00da08610 ("selftests: forwarding: Add bridge MDB test")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@...il.com>
> ---
> v2: Avoid false check failures as seen by Jakub Kicinski.
> ---

Reviewed-by: Simon Horman <horms@...nel.org>