netdev - Re: [RFC PATCH net-next 4/7] net: ip: make fib_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172675702580.6616.12370018117434278479@kwain.local>
Date: Thu, 19 Sep 2024 16:43:45 +0200
From: Antoine Tenart <atenart@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>, edumazet@...gle.com
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, steffen.klassert@...unet.com, herbert@...dor.apana.org.au, dongml2@...natelecom.cn, bigeasy@...utronix.de, toke@...hat.com, idosch@...dia.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [RFC PATCH net-next 4/7] net: ip: make fib_validate_source() return drop reason

Quoting Menglong Dong (2024-09-19 11:41:44)
>  
> @@ -2339,8 +2345,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
>         if (!ipv4_is_zeronet(saddr)) {
>                 err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
>                                           in_dev, &itag);
> -               if (err < 0)
> +               if (err < 0) {
> +                       err = -EINVAL;
> +                       __reason = -err;

That should be:

    __reason = -err;
    err = -EINVAL;


Also this patch should take care of the fib_validate_source call in
ip_mc_validate_source.

Thanks!
Antoine