netdev - Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd84c2d8-1571-41e9-8562-a4db232fbc38@redhat.com>
Date: Thu, 19 Sep 2024 11:12:04 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Florian Kauer <florian.kauer@...utronix.de>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Toke Høiland-Jørgensen <toke@...hat.com>,
 David Ahern <dsahern@...nel.org>, Hangbin Liu <liuhangbin@...il.com>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jesper Dangaard Brouer <brouer@...hat.com>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect

On 9/11/24 10:41, Florian Kauer wrote:
> rxq contains a pointer to the device from where
> the redirect happened. Currently, the BPF program
> that was executed after a redirect via BPF_MAP_TYPE_DEVMAP*
> does not have it set.
> 
> Add bugfix and related selftest.
> 
> Signed-off-by: Florian Kauer <florian.kauer@...utronix.de>
> ---
> Changes in v4:
> - return -> goto out_close, thanks Toke
> - Link to v3: https://lore.kernel.org/r/20240909-devel-koalo-fix-ingress-ifindex-v3-0-66218191ecca@linutronix.de
> 
> Changes in v3:
> - initialize skel to NULL, thanks Stanislav
> - Link to v2: https://lore.kernel.org/r/20240906-devel-koalo-fix-ingress-ifindex-v2-0-4caa12c644b4@linutronix.de
> 
> Changes in v2:
> - changed fixes tag
> - added selftest
> - Link to v1: https://lore.kernel.org/r/20240905-devel-koalo-fix-ingress-ifindex-v1-1-d12a0d74c29c@linutronix.de
> 
> ---
> Florian Kauer (2):
>        bpf: devmap: provide rxq after redirect
>        bpf: selftests: send packet to devmap redirect XDP
> 
>   kernel/bpf/devmap.c                                |  11 +-
>   .../selftests/bpf/prog_tests/xdp_devmap_attach.c   | 114 +++++++++++++++++++--
>   2 files changed, 115 insertions(+), 10 deletions(-)

Alex, Daniel: this will go directly via the bpf tree, right?

Thanks,

Paolo