netdev - Re: [PATCH net v5 1/2] net: sched: fix use-after-free in taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a2e969a-4a17-42a7-902b-d8aca4e59297@yandex.ru>
Date: Fri, 20 Sep 2024 12:05:49 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 lvc-project@...uxtesting.org,
 syzbot+b65e0af58423fc8a73aa@...kaller.appspotmail.com,
 Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [PATCH net v5 1/2] net: sched: fix use-after-free in
 taprio_change()

Just a friendly reminder. Note the net-next counterpart of this
series (https://lore.kernel.org/netdev/87wmjqnufp.fsf@intel.com/T/#t)
is already merged (both to net and net-next).

Dmitry

On 9/5/24 3:43 PM, Vinicius Costa Gomes wrote:
> Dmitry Antipov <dmantipov@...dex.ru> writes:
> 
>> In 'taprio_change()', 'admin' pointer may become dangling due to sched
>> switch / removal caused by 'advance_sched()', and critical section
>> protected by 'q->current_entry_lock' is too small to prevent from such
>> a scenario (which causes use-after-free detected by KASAN). Fix this
>> by prefer 'rcu_replace_pointer()' over 'rcu_assign_pointer()' to update
>> 'admin' immediately before an attempt to schedule freeing.
>>
>> Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
>> Reported-by: syzbot+b65e0af58423fc8a73aa@...kaller.appspotmail.com
>> Closes: https://syzkaller.appspot.com/bug?extid=b65e0af58423fc8a73aa
>> Signed-off-by: Dmitry Antipov <dmantipov@...dex.ru>
>> ---
>> v5: unchanged since v4 but resend due to series change
>> v4: adjust subject to target net tree
>> v3: unchanged since v2
>> v2: unchanged since v1
>> ---
> 
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> 
> 
> Cheers,