[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALNs47sKXVrMdC-vraJG3gt-b6yDWvFTOvfrL6+G=j6-1Y-BYQ@mail.gmail.com>
Date: Fri, 20 Sep 2024 17:42:10 +0200
From: Trevor Gross <tmgross@...ch.edu>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net] net: phy: qt2025: Fix warning: unused import DeviceId
On Thu, Sep 19, 2024 at 6:39 AM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> Fix the following warning when the driver is compiled as built-in:
>
> >> warning: unused import: `DeviceId`
> --> drivers/net/phy/qt2025.rs:18:5
> |
> 18 | DeviceId, Driver,
> | ^^^^^^^^
> |
> = note: `#[warn(unused_imports)]` on by default
The >> shows up as a quote on lore. Should this entire block be indented?
> device_table in module_phy_driver macro is defined only when the
> driver is built as module. Use an absolute module path in the macro
nit: "as module" -> "as a module"
> instead of importing `DeviceId`.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> ---
Easy enough fix, thanks for being on top of it.
Reviewed-by: Trevor Gross <tmgross@...ch.edu>
Powered by blists - more mailing lists