netdev - Re: [PATCH net] net: phy: qt2025: Fix warning: unused import DeviceId

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240921.050537.1209337185316346637.fujita.tomonori@gmail.com>
Date: Sat, 21 Sep 2024 05:05:37 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: tmgross@...ch.edu
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, andrew@...n.ch, lkp@...el.com
Subject: Re: [PATCH net] net: phy: qt2025: Fix warning: unused import
 DeviceId

On Fri, 20 Sep 2024 17:42:10 +0200
Trevor Gross <tmgross@...ch.edu> wrote:

> On Thu, Sep 19, 2024 at 6:39 AM FUJITA Tomonori
> <fujita.tomonori@...il.com> wrote:
>>
>> Fix the following warning when the driver is compiled as built-in:
>>
>> >> warning: unused import: `DeviceId`
>>    --> drivers/net/phy/qt2025.rs:18:5
>>    |
>>    18 |     DeviceId, Driver,
>>    |     ^^^^^^^^
>>    |
>>    = note: `#[warn(unused_imports)]` on by default
> 
> The >> shows up as a quote on lore. Should this entire block be indented?

Ah, I just copy and paste the original mail without thinking. I'll
drop ">>".

>> device_table in module_phy_driver macro is defined only when the
>> driver is built as module. Use an absolute module path in the macro
> 
> nit: "as module" -> "as a module"

Oops, I'll update the commit log and send v2.

>> instead of importing `DeviceId`.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
>> ---
> 
> Easy enough fix, thanks for being on top of it.
> 
> Reviewed-by: Trevor Gross <tmgross@...ch.edu>

Thanks!