netdev - Re: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aca8eab-f4d2-4474-acc9-c5c94dcb9162@web.de>
Date: Sun, 22 Sep 2024 19:55:13 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 Clayton Rayment <clayton.rayment@...inx.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Michal Simek <michal.simek@....com>,
 Paolo Abeni <pabeni@...hat.com>,
 Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc: LKML <linux-kernel@...r.kernel.org>, Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH] net: xilinx: axienet: Use common error handling code in
 axienet_mdio_write()

>> Add a label so that a bit of exception handling can be better reused
>> at the end of this function implementation.
…
> This change seems reasonable to me.

Thanks for this positive feedback.

>                                      However, I am assuming that as a
> non-bug-fix,

Would you like to categorise my update suggestion as a correction for
a coding style issue?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11#n526

>              this is targeted at net-next.  And net-next is currently
> closed for the v6.12 merge window.  Please consider reposting this patch
> once net-next reopens.

Will a patch resend really be needed for the proposed adjustment?

Can both development branches benefit from this refactoring?

Regards,
Markus