netdev - Re: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error pointer check in otx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKBCKMho+hh1GLD=XP1wOjDwy=DiD-SsAng8jCR6uAmPXgL-w@mail.gmail.com>
Date: Mon, 23 Sep 2024 21:24:42 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com, 
	hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, cc=linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error
 pointer check in otx2_common.c

Hi,

On Mon, 23 Sept 2024 at 21:17, Maxime Chevallier
<maxime.chevallier@...tlin.com> wrote:
>
> Hi,
>
> On Mon, 23 Sep 2024 11:06:32 +0000
> Dipendra Khadka <kdipendra88@...il.com> wrote:
>
> > Add error pointer check after calling otx2_mbox_get_rsp().
>
> As this is a fix, you need a Fixes: tag.
>
> > Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > index 87d5776e3b88..6e5f1b2e8c52 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > @@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
> >               rsp = (struct nix_hw_info *)
> >                      otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
> >
> > +             if (IS_ERR(rsp)) {
> > +                     mutex_unlock(&pfvf->mbox.lock);
> > +                     return PTR_ERR(rsp);
> > +             }
>
> You're returning an error code as the max MTU, which will be propagated
> to netdev->max_mtu, that's not correct. There's already an error path in
> this function that you can use.
>

Sure, thanks for the response. I will send a v2 .

> Thanks,
>
> Maxime

Best regards,
Dipendra