netdev - Re: [PATCH net-next] net: ethernet: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4037d375-191f-4e7b-ba87-f5ec9f0e32a2@gmail.com>
Date: Mon, 23 Sep 2024 11:26:34 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: Switch back to struct
 platform_driver::remove()

On 9/23/24 09:22, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert ethernet clk drivers to use .remove(), with the eventual goal to drop
> struct platform_driver::remove_new(). As .remove() and .remove_new() have
> the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> I converted all drivers below drivers/net/ethernet in a single patch. If
> you want it split, just tell me (per vendor? per driver?). Also note I
> didn't add all the maintainers of the individual drivers to Cc: to not
> trigger sending restrictions and spam filters.
> 
> Best regards
> Uwe
> 
>   drivers/net/ethernet/8390/ax88796.c                        | 2 +-
>   drivers/net/ethernet/8390/mcf8390.c                        | 2 +-
>   drivers/net/ethernet/8390/ne.c                             | 2 +-
>   drivers/net/ethernet/actions/owl-emac.c                    | 2 +-
>   drivers/net/ethernet/aeroflex/greth.c                      | 2 +-
>   drivers/net/ethernet/allwinner/sun4i-emac.c                | 2 +-
>   drivers/net/ethernet/altera/altera_tse_main.c              | 2 +-
>   drivers/net/ethernet/amd/au1000_eth.c                      | 2 +-
>   drivers/net/ethernet/amd/sunlance.c                        | 2 +-
>   drivers/net/ethernet/amd/xgbe/xgbe-platform.c              | 2 +-
>   drivers/net/ethernet/apm/xgene-v2/main.c                   | 2 +-
>   drivers/net/ethernet/apm/xgene/xgene_enet_main.c           | 2 +-
>   drivers/net/ethernet/apple/macmace.c                       | 2 +-
>   drivers/net/ethernet/arc/emac_rockchip.c                   | 2 +-
>   drivers/net/ethernet/broadcom/asp2/bcmasp.c                | 2 +-
>   drivers/net/ethernet/broadcom/bcm4908_enet.c               | 2 +-
>   drivers/net/ethernet/broadcom/bcm63xx_enet.c               | 4 ++--
>   drivers/net/ethernet/broadcom/bcmsysport.c                 | 2 +-
>   drivers/net/ethernet/broadcom/bgmac-platform.c             | 2 +-
>   drivers/net/ethernet/broadcom/genet/bcmgenet.c             | 2 +-
>   drivers/net/ethernet/broadcom/sb1250-mac.c                 | 2 +-

For drivers/net/ethernet/broadcom/:

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian