netdev - Re: [PATCH] net: expose __sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+PnFohFa3Q0DhcVS129u8NVbtnNkUvgCFRKocgP2Ekrw@mail.gmail.com>
Date: Mon, 23 Sep 2024 21:00:16 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Sahand Akbarzadeh <sahandevs@...il.com>
Cc: Jordan Rife <jrife@...gle.com>, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: expose __sock_sendmsg() symbol

On Mon, Sep 23, 2024 at 8:45 PM Sahand Akbarzadeh <sahandevs@...il.com> wrote:
>
> Yes, existing program still need some modification in order to work and
> are already broken (from kernel 6.8 to master branch) for some time. The issue
> here is there is no direct probe equivalent one could use to update those scripts.
>
> By adding `__sock_sendmsg`, one could attach based on kernel version or do something
> like this:
>
> sudo bpftrace -e 'kprobe:sock_sendmsg,kprobe:__sock_sendmsg {}'
>
> which only throws a warning if it can't find the `__sock_sendmsg`
>
> - Sahand

Convention on netdev mailing list is to not top post.

Removing the static is not enough, a compiler and linker can
completely inline / delete this function.

Anyway, I do not think sock_sendmsg() was part of any ABI.

If it was ABI, we would have to reinstate sock_sendmsg(), not making
__sock_sendmsg() visible.