netdev - RE: [PATCH net v3 1/1] net: ethernet: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089E94A9C5795B9A7B75424D66F2@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 23 Sep 2024 21:54:14 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Aleksander Jan Bajkowski <olek2@...pl>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "john@...ozen.org" <john@...ozen.org>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>, "ralph.hempel@...tiq.com"
	<ralph.hempel@...tiq.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net v3 1/1] net: ethernet: lantiq_etop: fix memory
 disclosure



> -----Original Message-----
> From: Aleksander Jan Bajkowski <olek2@...pl>
> Sent: Monday, September 23, 2024 2:50 PM
> To: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; olek2@...pl; horms@...nel.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; john@...ozen.org; ralf@...ux-mips.org;
> ralph.hempel@...tiq.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH net v3 1/1] net: ethernet: lantiq_etop: fix memory disclosure
> 
> When applying padding, the buffer is not zeroed, which results in memory
> disclosure. The mentioned data is observed on the wire. This patch uses
> skb_put_padto() to pad Ethernet frames properly. The mentioned function
> zeroes the expanded buffer.
> 
> In case the packet cannot be padded it is silently dropped. Statistics
> are also not incremented. This driver does not support statistics in the
> old 32-bit format or the new 64-bit format. These will be added in the
> future. In its current form, the patch should be easily backported to
> stable versions.
> 
> Ethernet MACs on Amazon-SE and Danube cannot do padding of the packets
> in hardware, so software padding must be applied.
> 
> Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>