netdev - Re: [PATCH v2 19/25] netfs: Speed up buffered reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <961634.1727130830@warthog.procyon.org.uk>
Date: Mon, 23 Sep 2024 23:33:50 +0100
From: David Howells <dhowells@...hat.com>
To: Eduard Zingerman <eddyz87@...il.com>
Cc: dhowells@...hat.com, Manu Bretelle <chantr4@...il.com>,
    asmadeus@...ewreck.org, ceph-devel@...r.kernel.org,
    christian@...uner.io, ericvh@...nel.org, hsiangkao@...ux.alibaba.com,
    idryomov@...il.com, jlayton@...nel.org,
    linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org,
    linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org, linux-mm@...ck.org,
    linux-nfs@...r.kernel.org, marc.dionne@...istor.com,
    netdev@...r.kernel.org, netfs@...ts.linux.dev, pc@...guebit.com,
    smfrench@...il.com, sprasad@...rosoft.com, tom@...pey.com,
    v9fs@...ts.linux.dev, willy@...radead.org
Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading

Eduard Zingerman <eddyz87@...il.com> wrote:

> - null-ptr-deref is triggered by access to page->pcp_list.next
>   when list_del() is called from page_alloc.c:__rmqueue_pcplist(),

Can you tell me what the upstream commit ID of your kernel is?  (before any
patches are stacked on it)

If you can modify your kernel, can you find the following in fs/netfs/:

buffered_read.c:127:			new = kmalloc(sizeof(*new), GFP_NOFS);
buffered_read.c:353:	folioq = kmalloc(sizeof(*folioq), GFP_KERNEL);
buffered_read.c:458:	folioq = kmalloc(sizeof(*folioq), GFP_KERNEL);
misc.c:25:		tail = kmalloc(sizeof(*tail), GFP_NOFS);

and change the kmalloc to kzalloc?

David