netdev - Bug? xpcs-wx: read-modify-write to different registers?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvEyZGKt5elazWfj@shell.armlinux.org.uk>
Date: Mon, 23 Sep 2024 10:18:28 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org
Subject: Bug? xpcs-wx: read-modify-write to different registers?

Hi,

While making some cleanups to the XPCS driver, I spotted the following
in pcs-xpcs-wx.c:

        val = txgbe_read_pma(xpcs, TXGBE_RX_GEN_CTL3);
        val = u16_replace_bits(val, 0x4, TXGBE_RX_GEN_CTL3_LOS_TRSHLD0);
        txgbe_write_pma(xpcs, TXGBE_RX_EQ_ATTN_CTL, val);

This reads from the TXGBE_RX_GEN_CTL3 register, changes a value in a
field, and then writes it back to a different register,
TXGBE_RX_EQ_ATTN_CTL. This doesn't look correct.

Please check whether this code is correct, if not please submit a fix.

Thanks.

Russell.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!