[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <637aca9a-5d1e-6726-4b97-4d5db0ee30a3@mediatek.com>
Date: Mon, 23 Sep 2024 18:43:23 +0800
From: Macpaul Lin <macpaul.lin@...iatek.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>, "AngeloGioacchino Del
Regno" <angelogioacchino.delregno@...labora.com>
CC: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>, "David S . Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, "Liam
Girdwood" <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Sean Wang
<sean.wang@...iatek.com>, Sen Chu <sen.chu@...iatek.com>,
<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>, Dmitry Torokhov
<dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>, Lee Jones
<lee@...nel.org>, Sebastian Reichel <sre@...nel.org>, Chen Zhong
<chen.zhong@...iatek.com>, <linux-input@...r.kernel.org>,
<linux-leds@...r.kernel.org>, <linux-pm@...r.kernel.org>,
<linux-rtc@...r.kernel.org>, <linux-sound@...r.kernel.org>, Alexandre Mergnat
<amergnat@...libre.com>, Bear Wang <bear.wang@...iatek.com>, Pablo Sun
<pablo.sun@...iatek.com>, Macpaul Lin <macpaul@...il.com>, Chris-qj chen
<chris-qj.chen@...iatek.com>, MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai
<wenst@...omium.org>
Subject: Re: [PATCH v6 2/2] dt-bindings: mfd: mediatek: mt6397: Convert to DT
schema format
On 9/20/24 21:37, Alexandre Belloni wrote:
[snip]
>> > > > > - RTC:
>> > > > > - Drop "start-year"
>> > > >
[snip]
>> >
>>
>> Alexandre, I definitely agree with you on the fact that the MTK PMIC RTC driver
>> can (and needs to) be improved, and that it can make use of some nice cleanup...
>>
>> ... but!
>>
>> This series performs a conversion to schema, and the previous txt file didn't
>> say anything about the start-year property - which was not mandatory to support
>> at that time (nor now, afaik?), so adding support for that is out of scope for
>> this series.
>
> It is mandatory now. I agree this can be done in a subsequent series.
>
Thanks you all for helping with the review and kindly understanding the
situation. I see that Angelo has already submitted the RTC patch set.
I'll check it with the internal driver owner. It seems okay with a quick
glance.
>>
>> Eventually, that can come as a series on top, adding support for that in the
>> binding (and, of course, in the driver).
>>
>> I should be able to tackle that... most probably next week - but still, the
>> improvements would come as a series on top of this one.
>>
>> Cheers,
>> Angelo
>
Thanks
Macpaul Lin
Powered by blists - more mailing lists