netdev - Re: [PATCH v2] mac802154: Fix potential RCU dereference issue in mac802154_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b1e94ce-f4c1-44d4-afbe-fe2dfca51de5@datenfreihafen.org>
Date: Mon, 23 Sep 2024 14:40:40 +0200
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Jiawei Ye <jiawei.ye@...mail.com>, miquel.raynal@...tlin.com
Cc: alex.aring@...il.com, davem@...emloft.net, david.girault@...vo.com,
 edumazet@...gle.com, kuba@...nel.org, linux-kernel@...r.kernel.org,
 linux-wpan@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com,
 przemyslaw.kitszel@...el.com
Subject: Re: [PATCH v2] mac802154: Fix potential RCU dereference issue in
 mac802154_scan_worker

Hello.

On 9/21/24 07:22, Jiawei Ye wrote:
> Hi Miquèl,
> 
> I'm sorry for the accidental email sent while testing my email setup. Please disregard the previous message.
> 
> On 9/20/24 19:21, Miquel Raynal wrote:
>> Hi Jiawei,
>>
>> jiawei.ye@...mail.com wrote on Fri, 20 Sep 2024 04:03:32 +0000:
>>
>>> In the `mac802154_scan_worker` function, the `scan_req->type` field was
>>> accessed after the RCU read-side critical section was unlocked. According
>>> to RCU usage rules, this is illegal and can lead to unpredictable
>>> behavior, such as accessing memory that has been updated or causing
>>> use-after-free issues.
>>>
>>> This possible bug was identified using a static analysis tool developed
>>> by myself, specifically designed to detect RCU-related issues.
>>>
>>> To address this, the `scan_req->type` value is now stored in a local
>>> variable `scan_req_type` while still within the RCU read-side critical
>>> section. The `scan_req_type` is then used after the RCU lock is released,
>>> ensuring that the type value is safely accessed without violating RCU
>>> rules.
>>>
>>> Fixes: e2c3e6f53a7a ("mac802154: Handle active scanning")
>>> Signed-off-by: Jiawei Ye <jiawei.ye@...mail.com>
>>
>> I think net maintainers now expect the Cc: stable tag to be put here
>> when there is a reason to backport, which I believe is the case here.
>> So please add this line here.
>>
> 
> Does this mean I should use Cc: stable@...r.kernel.org? I am not familiar with this procedure.

Yes.

>>>
>>
>> Please delete this blank line as well.
>>
>> And with that you can add my:
>>
>> Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>
>>
>>> ---
>>
>> Thanks,
>> Miquèl
> 
> Do I need to resend patch v2 with the "Resend" label?

Please make it a v3 right away, the resend with changes is to confusing 
for maintainers to keep up what to apply.

In your case remove the blank line, add the stable cc and I am happy to 
apply this.

regards
Stefan Schmidt