netdev - Re: [PATCH net 2/2] net: Fix gso_features_check to check for both dev->gso_{ipv4_,}max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5de4c73d-52e5-4c50-b1a2-faef3c0d01c7@gmail.com>
Date: Tue, 24 Sep 2024 14:16:49 +0200
From: Eric Dumazet <eric.dumazet@...il.com>
To: Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: Fix gso_features_check to check for both
 dev->gso_{ipv4_,}max_size


On 9/23/24 11:22 PM, Daniel Borkmann wrote:
> Commit 24ab059d2ebd ("net: check dev->gso_max_size in gso_features_check()")
> added a dev->gso_max_size test to gso_features_check() in order to fall
> back to GSO when needed.
>
> This was added as it was noticed that some drivers could misbehave if TSO
> packets get too big. However, the check doesn't respect dev->gso_ipv4_max_size
> limit. For instance, a device could be configured with BIG TCP for IPv4,
> but not IPv6.
>
> Therefore, add a netif_get_gso_max_size() equivalent to netif_get_gro_max_size()
> and use the helper to respect both limits before falling back to GSO engine.
>
> Fixes: 24ab059d2ebd ("net: check dev->gso_max_size in gso_features_check()")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
> ---


Reviewed-by: Eric Dumazet <edumazet@...gle.com>